fix type hint in DiffusionConfig and remove Literal#1088
Merged
Conversation
Contributor
Author
|
cscs-ci run default |
Contributor
Author
|
cscs-ci run distributed |
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
Contributor
Author
|
cscs-ci run default |
Contributor
Author
|
cscs-ci run distributed |
1 similar comment
Contributor
Author
|
cscs-ci run distributed |
Contributor
Author
|
cscs-ci run default |
OngChia
changed the title
msimberg
approved these changes
Mar 3, 2026
jcanton
added a commit
that referenced
this pull request
Mar 3, 2026
* main: Remove `vct_b` bindings only (#1082) Replace `pg_edgeidx_dsl` mask by multiplying with 0.0 (#1053) Replace `mask_hdiff` by multiplying with 0.0 (#1056) fix type hint in DiffusionConfig and remove Literal (#1088) muphys: graupel py2fgen bindings (#1073) Fix mypy warnings for DiffusionConfig (#1086) Add tracer advection to standalone driver [cycle 34] (#1039) Reject namelist parameters not supported (#1079) Update to gt4py v1.1.6 (#1081) Merge bdy halo stencils (#1066) Enable gauss3d experiment for distributed tests (#1013) Reenable MPS in CI (#1057) Don't compute RBF coefficients over whole domain to avoid non-positive definite matrices (#1077) muphys: Only write the surface level of the fluxes (#995) Update to gt4py v1.1.5 (#1072)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Valid** type Literal declaration for the config parameters
DiffusionType,SmagorinskyStencilType,TemperatureDiscretizationType, andTurbulenceShearForcingTypein DiffusionConfig after this PR#1079 was merged. They are unnecessary because they are all Enum type (refer to comments in this PR#1086).Moreover, this PR fixes some additional places where
type_t_diffu(TemperatureDiscretizationType) andtype_vn_diffu(SmagorinskyStencilType) are still passed as int.